[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 24/49] target-i386: Remove gen_op_movl_T0_im*
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PULL 24/49] target-i386: Remove gen_op_movl_T0_im* |
Date: |
Thu, 23 Jan 2014 09:03:43 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/23/2014 07:24 AM, Kevin Wolf wrote:
>> > @@ -6508,12 +6498,11 @@ static target_ulong disas_insn(CPUX86State *env,
>> > DisasContext *s,
>> > else
>> > ot = dflag ? MO_32 : MO_16;
>> > val = cpu_ldub_code(env, s->pc++);
>> > - gen_op_movl_T0_im(val);
>> > gen_check_io(s, ot, pc_start - s->cs_base,
>> > SVM_IOIO_TYPE_MASK | svm_is_rep(prefixes));
> This removal is wrong. gen_check_io() uses cpu_T[0] internally in order
> to check the I/O bitmap. Now I get a #GP even for legitimate cases.
>
> The following patch (which is essentially a partial revert) makes it
> work for me again. Should I send it as a proper patch or would you
> prefer to clean up gen_check_io()? I guess some more explicit passing of
> the port number couldn't hurt there, but I'm not familiar with TCG and
> who knows what I would break while doing this...
Oops. How did that happen?
Please just send this as a proper patch and we'll worry about cleanup of
gen_check_io later. You can add my
Reviewed-by: Richard Henderson <address@hidden>
when you send it. Via qemu-trivial?
r~
- [Qemu-devel] [PULL 15/49] target-i386: Tidy mov[sz][bw], (continued)
- [Qemu-devel] [PULL 15/49] target-i386: Tidy mov[sz][bw], Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 16/49] target-i386: Tidy movsl, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 17/49] target-i386: Remove unused arguments to gen_lea_modrm, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 18/49] target-i386: Use MO_BE for movbe, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 19/49] target-i386: Tidy gen_op_mov_TN_reg+tcg_gen_trunc_tl_i32, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 20/49] target-i386: Tidy load + truncate, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 21/49] target-i386: Tidy extend + store, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 22/49] target-i386: Tidy extend + move, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 24/49] target-i386: Remove gen_op_movl_T0_im*, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 23/49] target-i386: Remove gen_op_movl_T0_0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 25/49] target-i386: Remove gen_op_movl_T0_im*, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 27/49] target-i386: Remove gen_movtl_T*_im, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 26/49] target-i386: Remove gen_op_mov*_A0_im, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 28/49] target-i386: Remove gen_op_andl_T0_ffff, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 30/49] target-i386: Remove gen_op_movl_T0_T1, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 29/49] target-i386: Remove gen_op_andl_T0_im, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 31/49] target-i386: Remove gen_op_andl_A0_ffff, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 32/49] target-i386: Use TCGMemOp for 'ot' variables, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 33/49] target-i386: Change gen_op_add_reg_* size parameter to TCGMemOp, Richard Henderson, 2014/01/07