[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 25/29] iscsi: Set bs->request_alignment
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH v3 25/29] iscsi: Set bs->request_alignment |
Date: |
Fri, 24 Jan 2014 17:29:20 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Le Friday 17 Jan 2014 à 15:15:15 (+0100), Kevin Wolf a écrit :
> From: Paolo Bonzini <address@hidden>
>
> The iSCSI backend already gets the block size from the READ CAPACITY
> command it sends. Save it so that the generic block layer gets it
> too.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> block/iscsi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 3202dc5..23c3fc4 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1217,6 +1217,7 @@ static int iscsi_open(BlockDriverState *bs, QDict
> *options, int flags,
> goto out;
> }
> bs->total_sectors = sector_lun2qemu(iscsilun->num_blocks, iscsilun);
> + bs->request_alignment = iscsilun->block_size;
>
> /* Medium changer or tape. We dont have any emulation for this so this
> must
> * be sg ioctl compatible. We force it to be sg, otherwise qemu will try
> --
> 1.8.1.4
>
>
Reviewed-by: Benoit Canet <address@hidden>
- Re: [Qemu-devel] [PATCH v3 19/29] block: Allow wait_serialising_requests() at any point, (continued)
- [Qemu-devel] [PATCH v3 20/29] block: Align requests in bdrv_co_do_pwritev(), Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 21/29] block: Assert serialisation assumptions in pwritev, Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 22/29] block: Change coroutine wrapper to byte granularity, Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 23/29] block: Make bdrv_pread() a bdrv_prwv_co() wrapper, Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 25/29] iscsi: Set bs->request_alignment, Kevin Wolf, 2014/01/17
- Re: [Qemu-devel] [PATCH v3 25/29] iscsi: Set bs->request_alignment,
Benoît Canet <=
- [Qemu-devel] [PATCH v3 24/29] block: Make bdrv_pwrite() a bdrv_prwv_co() wrapper, Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 26/29] blkdebug: Make required alignment configurable, Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 27/29] qemu-io: New command 'sleep', Kevin Wolf, 2014/01/17
- [Qemu-devel] [PATCH v3 28/29] qemu-iotests: Test pwritev RMW logic, Kevin Wolf, 2014/01/17