Re: [Qemu-devel] [PATCH target-arm v5 1/5] arm: zynq: Macroify OCM Base and Size

[Peter Maydell]

On 15 January 2014 09:13, Peter Crosthwaite
<address@hidden> wrote:
> Convert magic numbers for OCM to Macros.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>
>  hw/arm/xilinx_zynq.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
> index 98e0958..33a47e0 100644
> --- a/hw/arm/xilinx_zynq.c
> +++ b/hw/arm/xilinx_zynq.c
> @@ -36,7 +36,9 @@
>
>  #define IRQ_OFFSET 32 /* pic interrupts start from index 32 */
>
> -#define MPCORE_PERIPHBASE 0xF8F00000
> +#define MPCORE_PERIPHBASE   0xF8F00000
> +#define OCM_BASE            0xfffc0000
> +#define OCM_SIZE            (256 << 10)

Consistency in whether we capitalize the hex constants
or not would be nice :-)

Also, I think your patch subject prefixes are a bit nonstandard.

thanks
-- PMM