qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 01/11] target-arm: Move arm_rmode_to_sf to a


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2 01/11] target-arm: Move arm_rmode_to_sf to a shared location.
Date: Tue, 28 Jan 2014 15:05:03 +0000

On 28 January 2014 11:22, Will Newton <address@hidden> wrote:
> This function will be needed for AArch32 ARMv8 support, so move it to
> helper.c where it can be used by both targets. Also moves the code out
> of line, but as it is quite a large function I don't believe this
> should be a significant performance impact

I've reviewed and tested patches 1..10 of this series, and
applied them to target-arm.next. Patch 11 I'm going to make
some review comments on.

PS: please don't forget the cover letter next time you send
a multipatch series.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]