Re: [Qemu-devel] [uq/master PATCH 4/7] target-i386: Rename cpu_x86_register() to x86_cpu_load_def()

[Paolo Bonzini]

Il 30/01/2014 20:48, Eduardo Habkost ha scritto:
> There isn't any kind of "registration" involved in cpu_x86_register()
> anymore: it is simply looking up a CPU model name and loading the model
> definition data into the X86CPU object. Rename it to x86_cpu_load_def()
> to reflect what it does.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  target-i386/cpu.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 0e8812a..58b4c71 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1817,7 +1817,9 @@ static void filter_features_for_kvm(X86CPU *cpu)
>      }
>  }
>
> -static void cpu_x86_register(X86CPU *cpu, const char *name, Error **errp)
> +/* Load CPU definition for a given CPU model name
> + */
> +static void x86_cpu_load_def(X86CPU *cpu, const char *name, Error **errp)
>  {
>      CPUX86State *env = &cpu->env;
>      x86_def_t def1, *def = &def1;
> @@ -1900,7 +1902,7 @@ X86CPU *cpu_x86_create(const char *cpu_model, DeviceState 
> *icc_bridge,
>      object_unref(OBJECT(cpu));
>  #endif
>
> -    cpu_x86_register(cpu, name, &error);
> +    x86_cpu_load_def(cpu, name, &error);
>      if (error) {
>          goto out;
>      }

Reviewed-by: Paolo Bonzini <address@hidden>