|
From: | Max Reitz |
Subject: | Re: [Qemu-devel] [PATCH V14 10/13] quorum: Add quorum_co_flush(). |
Date: | Mon, 03 Feb 2014 20:51:54 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 03.02.2014 20:11, Benoît Canet wrote:
From: Benoît Canet <address@hidden> Makes a vote to select error if any. Signed-off-by: Benoit Canet <address@hidden> --- block/quorum.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
See my reply to V10: You're only counting results which are not 0 (i.e., errors); therefore, 0 will never reach majority. If "error" is set to true (that is, if any error occured), "error_votes" will only contain values below 0 (i.e., errors), therefore, in that case, an error will be returned, regardless of how many calls succeeded.
Max
[Prev in Thread] | Current Thread | [Next in Thread] |