Re: [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size

[Orit Wasserman]

On 02/04/2014 06:26 PM, Eric Blake wrote:
> On 02/04/2014 08:19 AM, Juan Quintela wrote:
> > From: Orit Wasserman <address@hidden>
> >
> > Signed-off-by: Orit Wasserman <address@hidden>
> > Signed-off-by: Juan Quintela <address@hidden>
> > ---
> >   migration.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/migration.c b/migration.c
> > index 46a7305..25add6f 100644
> > --- a/migration.c
> > +++ b/migration.c
> > @@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Error 
> > **errp)
> >           return;
> >       }
> >
> > +    /* Cache should not be larger than guest ram size */
> > +    if (value > ram_bytes_total()) {
> > +        error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size",
> > +                  "exceeds guest ram size ");
>
> Trailing space in the error message.

I will send a separate patch to fix this.

Orit