Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

[Markus Armbruster]

Alexander Graf <address@hidden> writes:

> On 06.02.2014, at 15:41, Markus Armbruster <address@hidden> wrote:
>
>> Paolo Bonzini <address@hidden> writes:
>> 
>>> Il 04/02/2014 13:14, Markus Armbruster ha scritto:
>>>> Paolo Bonzini <address@hidden> writes:
>>>> 
>>>>> Il 04/02/2014 11:33, Markus Armbruster ha scritto:
>>>>>> 
>>>>>>    This breaks migration unless you change bus=ide.0 to bus=ide.1 on
>>>>>>    the destination.
>>>>>> 
>>>>>> Should be mentioned in release notes.  Do we have a place where we
>>>>>> collect release notes as we go?
>>>>> 
>>>>> Yes, http://wiki.qemu.org/ChangeLog/Next
>>>> 
>>>> I can record this change there, but I don't seem to have an account.
>>> 
>>> Created one, will send account details offlist.
>> 
>> I'll update the page when the patch gets committed.
>> 
>> Alex, want me to repost it with the commit message amended as outlined
>> in my review?
>
> Yes, please. I'm sure if I change it you'll find some nits again.

Believe me, I felt bad about nit-picking your commit message *again*.  I
would've refrained if it wasn't about breaking backwards compatibility.
I'm not overly adverse to that, but I am a stickler for describing
exactly what gets broken.  Hope I didn't try your patience too much...

Anyway, v4 just sent.