[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest |
Date: |
Fri, 7 Feb 2014 16:48:57 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas Färber wrote:
> +#include "libqtest.h"
> +
> +#include <glib.h>
> +#include <string.h>
> +#include "qemu/osdep.h"
Please put <system.h> includes before "user.h" includes. That way we
can be sure our macros don't mess up system headers.
> +
> +static void nop(void)
> +{
> +}
I suggest a comment here to explain the point of this test:
/* The point of this test case is just to instantiate the device */
- [Qemu-devel] [PATCH qom-next 0/5] qtest: Prepare PCI NIC tests, Andreas Färber, 2014/02/05
- [Qemu-devel] [PATCH qom-next 4/5] tests: Add PC-Net qtest, Andreas Färber, 2014/02/05
- [Qemu-devel] [PATCH qom-next 5/5] tests: Add eepro100 qtest, Andreas Färber, 2014/02/05
- [Qemu-devel] [PATCH qom-next 3/5] tests: Add rtl8139 qtest, Andreas Färber, 2014/02/05
- [Qemu-devel] [PATCH qom-next 2/5] tests: Add vmxnet3 qtest, Andreas Färber, 2014/02/05
- Re: [Qemu-devel] [PATCH qom-next 0/5] qtest: Prepare PCI NIC tests, Stefan Hajnoczi, 2014/02/07