[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] blkdebug: Don't leak bs->file on failure
|
From: |
Laszlo Ersek |
|
Subject: |
Re: [Qemu-devel] [PATCH] blkdebug: Don't leak bs->file on failure |
|
Date: |
Sat, 08 Feb 2014 10:57:24 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131118 Thunderbird/17.0.11 |
On 02/08/14 10:55, Kevin Wolf wrote:
> Am 08.02.2014 um 10:46 hat Laszlo Ersek geschrieben:
>> How about the attached patch instead? Releasing stuff in specific error
>> handler blocks quickly becomes intractable if there are many resources
>> to allocate in succession, but in this case I think we can easily get
>> away with it.
>
> I'd prefer to avoid this because it's too easy to miss it when you add
> new code to the function.
Oh, right. If you actually care about the future, this is a good point :)
Thanks!
Laszlo