Re: [Qemu-devel] [PATCH v2 0/2] qapi: Allow modularization of QAPI schema files

[Markus Armbruster]

Lluís Vilanova <address@hidden> writes:

> Adds the "include(...)" primitive to the syntax of QAPI schema files, allowing
> these to be modularized into multiple per-topic files in the future.
>
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
>
> Changes in v2:
>
> * Change the scripts to use an explicit input file instead of standard input.
> * Fix "tests/Makefile" to use the new argument.
> * Get the input directory for the "include" directive from the input file
>   dirname.
>
>
> Lluís Vilanova (2):
>       qapi: Use an explicit input file
>       qapi: Add a primitive to include other files from a QAPI schema file
>
>
>  Makefile                 |   24 ++++++++++++++++++------
>  scripts/qapi-commands.py |   10 +++++++---
>  scripts/qapi-types.py    |    9 ++++++---
>  scripts/qapi-visit.py    |    9 ++++++---
>  scripts/qapi.py          |   26 +++++++++++++++++++++++---
>  tests/Makefile           |   12 +++++++++---
>  6 files changed, 69 insertions(+), 21 deletions(-)

Diffstat shows that you forgot to include the tests :)

Suggest to rebase on top of my "[PATCH v2 00/13] qapi: Test coverage &
clean up generated code", then add suitable tests to tests/qapi-schema/.
Make sure to cover reporting of errors in included files.