[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/16] target-i386: cpu: convert 'model-id' to s
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 09/16] target-i386: cpu: convert 'model-id' to static property |
Date: |
Tue, 11 Feb 2014 09:36:08 -0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Nov 27, 2013 at 11:28:49PM +0100, Igor Mammedov wrote:
> * check "if (model_id == NULL)" looks unnecessary now, since all
> builtin model-ids are not NULL and user shouldn't be able to set
> it NULL (cpumodel string parsing code takes care of it, if feature
> is specified as "model-id=" on command line, its parsing will
> result in an empty string as value).
>
> Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
--
Eduardo
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 09/16] target-i386: cpu: convert 'model-id' to static property,
Eduardo Habkost <=