[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: Fix I/O bitmap checks for in/out
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: Fix I/O bitmap checks for in/out |
Date: |
Mon, 17 Feb 2014 11:14:56 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 24.01.2014 um 11:19 hat Kevin Wolf geschrieben:
> Commit 1b90d56e changed the implementation of in/out imm to not assign
> the accessed port number to cpu_T[0] as it appeared unnecessary.
> However, currently gen_check_io() makes use of cpu_T[0] to implement the
> I/O bitmap checks, so it's in fact still used and the change broke the
> check, leading to #GP in legitimate cases (and probably also allowing
> access to ports that shouldn't be allowed).
>
> This patch reintroduces the missing assignment for these cases.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
Ping?
/me considers sending a one-patch pull request for an area he's
absolutely not maintaining, but if this is the only way to get patches
applied to qemu...
Kevin
> ---
> target-i386/translate.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index b0f2279..5dd2450 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -6284,6 +6284,7 @@ static target_ulong disas_insn(CPUX86State *env,
> DisasContext *s,
> case 0xe5:
> ot = mo_b_d32(b, dflag);
> val = cpu_ldub_code(env, s->pc++);
> + tcg_gen_movi_tl(cpu_T[0], val);
> gen_check_io(s, ot, pc_start - s->cs_base,
> SVM_IOIO_TYPE_MASK | svm_is_rep(prefixes));
> if (use_icount)
> @@ -6300,6 +6301,7 @@ static target_ulong disas_insn(CPUX86State *env,
> DisasContext *s,
> case 0xe7:
> ot = mo_b_d32(b, dflag);
> val = cpu_ldub_code(env, s->pc++);
> + tcg_gen_movi_tl(cpu_T[0], val);
> gen_check_io(s, ot, pc_start - s->cs_base,
> svm_is_rep(prefixes));
> gen_op_mov_v_reg(ot, cpu_T[1], R_EAX);
> --
> 1.8.1.4
>
- Re: [Qemu-devel] [PATCH] target-i386: Fix I/O bitmap checks for in/out,
Kevin Wolf <=