[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 02/14] block: Introduce op_blockers to Block
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v13 02/14] block: Introduce op_blockers to BlockDriverState |
Date: |
Mon, 17 Feb 2014 21:30:40 +0800 |
User-agent: |
Mutt/1.5.22 (2013-10-16) |
On Thu, 02/13 13:37, Benoît Canet wrote:
> The Wednesday 29 Jan 2014 à 13:07:29 (+0800), Fam Zheng wrote :
> > diff --git a/include/block/block_int.h b/include/block/block_int.h
> > index 0bcf1c9..4e558d0 100644
> > --- a/include/block/block_int.h
> > +++ b/include/block/block_int.h
> > @@ -270,6 +270,8 @@ typedef struct BlockLimits {
> > size_t opt_mem_alignment;
> > } BlockLimits;
> >
> > +typedef struct BdrvOpBlocker BdrvOpBlocker;
> > +
> > /*
> > * Note: the function bdrv_append() copies and swaps contents of
> > * BlockDriverStates, so if you add new fields to this struct, please
> > @@ -361,6 +363,9 @@ struct BlockDriverState {
> >
> > QLIST_HEAD(, BdrvTrackedRequest) tracked_requests;
> >
> > + /* operation blockers */
> > + QLIST_HEAD(, BdrvOpBlocker) op_blockers[BLOCK_OP_TYPE_MAX];
>
> Is a loop doing QLIST_INIT on this array elements required ?
>
Yes, we better do it.
Thanks,
Fam