[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process |
Date: |
Mon, 17 Feb 2014 17:44:55 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Stefan Hajnoczi <address@hidden> writes:
> qtest_init() cannot use exec*p() to launch QEMU since the exec*p()
> functions take an argument array while qtest_init() takes char
> *extra_args. Therefore we execute /bin/sh -c <command-line> and let the
> shell parse the argument string.
>
> This left /bin/sh as our child process and our child's child was QEMU.
> We still want QEMU's pid so the -pidfile option was used to let QEMU
> report its pid.
>
> The pidfile needs to be unlinked when the test case exits or fails. In
> other words, the pidfile creates a new problem for us!
>
> Simplify all this using the shell 'exec' command. It allows us to
> replace the /bin/sh process with QEMU. Then we no longer need to use
> -pidfile because we already know our fork child's pid.
>
> Note: Yes, it seems silly to exec /bin/sh when we could just exec QEMU
> directly. But remember qtest_init() takes a single char *extra_args
> command-line fragment instead of a real argv[] array, so we need
> /bin/sh's argument parsing behavior.
Sounds like a design mistake to me.
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Patch looks good.
- [Qemu-devel] [PATCH 0/3] qtest: avoid pidfile and QEMU process leaks, Stefan Hajnoczi, 2014/02/17
- [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure, Stefan Hajnoczi, 2014/02/17
- Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure, Paolo Bonzini, 2014/02/17
- Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure, Markus Armbruster, 2014/02/17
- Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure, Stefan Hajnoczi, 2014/02/18
- Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure, Markus Armbruster, 2014/02/18
- Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure, Paolo Bonzini, 2014/02/18
- Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure, Markus Armbruster, 2014/02/18
- Re: [Qemu-devel] [PATCH 3/3] qtest: kill QEMU process on g_assert() failure, Stefan Hajnoczi, 2014/02/18