[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors |
Date: |
Tue, 18 Feb 2014 10:51:19 +0800 |
User-agent: |
Mutt/1.5.22 (2013-10-16) |
On Mon, 02/17 14:20, Paolo Bonzini wrote:
> Il 17/02/2014 14:15, Fam Zheng ha scritto:
> >Does this mean that error_is_set() is always used by programmer to check a
> >non-NULL error pointer? Is there any case to call error_is_set(errp) without
> >knowing if errp is NULL or not? If no, should we enforce the rule and add
> >assert(errp) in error_is_set()?
>
> I think we shouldn't need error_is_set() at all...
>
Thinking about both use cases (errp is NULL or not) and I agree to this.
Fam
- [Qemu-devel] [PATCH v3 06/20] iscsi: correctly propagate errors in iscsi_open, (continued)
- [Qemu-devel] [PATCH v2 08/20] gluster: correctly propagate errors, Paolo Bonzini, 2014/02/11
- [Qemu-devel] [PATCH v2 10/20] curl: correctly propagate errors, Paolo Bonzini, 2014/02/11
- [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Paolo Bonzini, 2014/02/11
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Kevin Wolf, 2014/02/14
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Jeff Cody, 2014/02/14
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Markus Armbruster, 2014/02/15
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Fam Zheng, 2014/02/17
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Paolo Bonzini, 2014/02/17
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Jeff Cody, 2014/02/17
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Kevin Wolf, 2014/02/17
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Markus Armbruster, 2014/02/17
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Fam Zheng, 2014/02/17
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Paolo Bonzini, 2014/02/14
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Kevin Wolf, 2014/02/14
- Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors, Paolo Bonzini, 2014/02/14
[Qemu-devel] [PATCH v2 11/20] qcow: correctly propagate errors, Paolo Bonzini, 2014/02/11
[Qemu-devel] [PATCH v2 12/20] qed: correctly propagate errors, Paolo Bonzini, 2014/02/11
[Qemu-devel] [PATCH v2 13/20] vhdx: correctly propagate errors, Paolo Bonzini, 2014/02/11
[Qemu-devel] [PATCH v2 14/20] vvfat: correctly propagate errors, Paolo Bonzini, 2014/02/11