Re: [Qemu-devel] [PATCH v2 2/6] qemu-img create: Support multiple -o options

[Eric Blake]

On 02/20/2014 08:52 AM, Eric Blake wrote:

> Previously:
> 
> qemu-img create -f qcow2 -o backing_file=/dev/null, xyz 1M
> 
> creates xyz with a backing file of /dev/null and unspecified backing
> format (and ignores the empty trailing option).

>   And maybe patch get_opt_value() to detect and reject empty
> trailing options as well.

Further evidence for my desire to improve get_opt_value() for
consistency: we already reject empty leading options...

$ qemu-img create -f qcow2 -o ,backing_file=/dev/null xyz 1MUnknown
option ''
qemu-img: xyz: Invalid options for file format 'qcow2'.

...although we happily ignore an empty option:

$ qemu-img create -f qcow2 -o '' xyz 1M
Formatting 'xyz', fmt=qcow2 size=1048576 encryption=off
cluster_size=65536 lazy_refcounts=off

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature