[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH target-arm v7 1/1] target-arm: Implements the AR
|
From: |
Alistair Francis |
|
Subject: |
Re: [Qemu-devel] [PATCH target-arm v7 1/1] target-arm: Implements the ARM PMCCNTR register |
|
Date: |
Fri, 21 Feb 2014 09:58:31 +1000 |
On Fri, Feb 21, 2014 at 1:44 AM, Peter Maydell <address@hidden> wrote:
> On 19 February 2014 23:57, Alistair Francis <address@hidden> wrote:
>> This patch implements the ARM PMCCNTR register including
>> the disable and reset components of the PMCR register.
>>
>> Signed-off-by: Alistair Francis <address@hidden>
>
> This breaks compilation of the arm-linux-user target
> (the qemu_clock_get_* functions are only available in
> system mode). You probably want to do something similar
> to how we handle the generic timers, where we #ifdef
> everything out. (I don't think Linux gives user
> space access to the perf monitor registers.)
>
> Other than that I think it looks good now.
>
> thanks
> -- PMM
>
What do you think the functions should do when in user space? Should
they just return 0?