[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism.
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism. |
|
Date: |
Fri, 21 Feb 2014 15:44:06 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/21/2014 03:38 PM, Kevin Wolf wrote:
>>>> +- "ret": The IO return code.
>>>
>>> What values is this likely to contain? Is it a finite set, in which
>>> case it would be nice to have a QAPI enum that describes the set of
>>> return codes, rather than a raw number?
>>
>> It's anything that the block stack could return as an error.
>
> In other words, it's meaning depends on the host and the value is only
> suitable for human readers. Perhaps we could change this to strerror(),
> which is, I believe, the same as error_setg_errno() does.
Ah, so you're saying that 'ret' would be a '-errno' value - in that
case, yes, converting it to string, and documenting this field as a
human-only strerror() representation of the error would also work (using
'str', rather than an enum type).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V19 10/12] quorum: Implement recursive .bdrv_recurse_is_first_non_filter in quorum., (continued)
- [Qemu-devel] [PATCH V19 10/12] quorum: Implement recursive .bdrv_recurse_is_first_non_filter in quorum., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 08/12] quorum: Add quorum_invalidate_cache()., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 04/12] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 01/12] quorum: Create quorum.c, add QuorumChildRequest and QuorumAIOCB., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 03/12] quorum: Add quorum_aio_writev and its dependencies., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 07/12] quorum: Add quorum_getlength()., Benoît Canet, 2014/02/21
- [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism., Benoît Canet, 2014/02/21
- Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism., Eric Blake, 2014/02/21
[Qemu-devel] [PATCH V19 05/12] quorum: Add quorum_aio_readv., Benoît Canet, 2014/02/21
Re: [Qemu-devel] [PATCH V19 00/12] Quorum block filter, Kevin Wolf, 2014/02/21
Re: [Qemu-devel] [PATCH V19 00/12] Quorum block filter, Eric Blake, 2014/02/21