[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qga: Fix memory allocation pasto
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH] qga: Fix memory allocation pasto |
Date: |
Sun, 23 Feb 2014 19:01:27 -0600 |
User-agent: |
alot/0.3.4 |
Quoting Markus Armbruster (2014-02-21 06:36:49)
> qmp_guest_file_seek() allocates memory for a GuestFileRead object
> instead of the GuestFileSeek object it actually uses. Harmless,
> because the GuestFileRead is slightly larger.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Thanks, applied to qga tree:
https://github.com/mdroth/qemu/commits/qga
> ---
> qga/commands-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index cae4171..2c496b6 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -525,7 +525,7 @@ struct GuestFileSeek *qmp_guest_file_seek(int64_t handle,
> int64_t offset,
> if (ret == -1) {
> error_setg_errno(err, errno, "failed to seek file");
> } else {
> - seek_data = g_malloc0(sizeof(GuestFileRead));
> + seek_data = g_new0(GuestFileSeek, 1);
> seek_data->position = ftell(fh);
> seek_data->eof = feof(fh);
> }
> --
> 1.8.1.4