[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 1/1] hda-audio: qom cleanups
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PULL 1/1] hda-audio: qom cleanups |
|
Date: |
Mon, 24 Feb 2014 13:32:24 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 24.02.2014 13:22, schrieb Gerd Hoffmann:
> Add HDA_AUDIO type and macro, drop DO_UPCAST().
>
> Had to add a abstract hda audio class as parent
> for all hda-* variants to make that fly. Killed
> some init code duplication while being at it.
>
> Cc: Andreas Färber <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/audio/hda-codec.c | 60
> ++++++++++++++++++++++++++++------------------------
> 1 file changed, 32 insertions(+), 28 deletions(-)
Looks good, including introduction of a base type, thanks for cleaning
this up. These devices are not used by default, right? Have you been
considering writing qtests for them or would you rather have me prepare
something?
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg