qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/7] timer: move APIs together according to thei


From: Alex Bligh
Subject: Re: [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category
Date: Tue, 25 Feb 2014 16:25:01 +0000

> 
> This patchset includes below changes:
> - put QEMUTimerList related functions together and make them private
> - put QEMUClockType related functions together
> - move QEMUTimerListGroup function to be below QEMUClockType
> - put QEMUTimer related functions together
> - put general utility functions together
> - clean unnecessary #include and use minimal required #include
> 
> Xuebing Wang (7):
>  timer: move QEMUTimerList functions together
>  timer: make QEMUTimerList functions private (remove from APIs)
>  timer: move QEMUClockType related functions together
>  timer: move QEMUTimerListGroup function to be below QEMUClockType
>  timer: move QEMUTimer related functions together
>  timer: move general utility functions together
>  timer: clean unnecessary #include and use minimal required #include


I'm generally in favour of this patch set or something like it. It's
nicely constrained to 2 include files. It appears to touch no code.
And it appears to makes things tidier.

Stefan / Paolo? If you agree I will review in greater detail.

-- 
Alex Bligh







reply via email to

[Prev in Thread] Current Thread [Next in Thread]