Re: [Qemu-devel] [PATCH 0/2 v4] vfio: blacklist loading of unstable roms

[Alex Williamson]

On Tue, 2014-02-25 at 18:47 -0500, Bandan Das wrote:
> v4:
> 1. Short Description of the issue in comments, pointer
> to qemu bug tracker in 2/2
> 2. Remove unnecessary check on rom_bar in vfio_pci_size_rom 2/2
> 3. No changes to 1/2 - Andreas, I have retained your "Reviewed-by"
> since the code hasn't changed.
> 
> v3:
> 1. Change the "force" logic to depend on whether the user specified rombar,
> eliminate dependence on multiple values of rom_bar
> 2. Avoid printing the informational message if there's no rom
> 3. Minor changes to commit messages
> 
> v2:
> 1. Break up into two patches separating the infrastructural changes
> 2. Change vendor_id and device_id type to uint16_t
> 3. Rename struct for blacklisted devid and vendorid to more meaningful names
> 4. Remove unnecessary rom_quirk variable and just call 
> vfio_blacklist_opt_rom()
> in vfio_pci_size_rom()
> 
> Bandan Das (2):
>   qdev-monitor: set DeviceState opts before calling realize
>   vfio: blacklist loading of unstable roms
> 
>  hw/misc/vfio.c | 73 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  qdev-monitor.c |  4 +++-
>  2 files changed, 76 insertions(+), 1 deletion(-)
> 

Applied, thanks!