[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/6] iothread: add I/O thread object
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/6] iothread: add I/O thread object |
Date: |
Fri, 28 Feb 2014 11:39:58 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 26, 2014 at 11:00:19AM +0100, Igor Mammedov wrote:
> On Fri, 21 Feb 2014 15:46:55 +0100
> Stefan Hajnoczi <address@hidden> wrote:
> > +char *iothread_get_id(IOThread *iothread)
> > +{
> > + /* The last path component is the identifier */
> > + char *path = object_get_canonical_path(OBJECT(iothread));
> > + char *id = g_strdup(&path[sizeof(IOTHREADS_PATH)]);
> > + g_free(path);
> > + return id;
> > +}
> it seems to be a more generic issue, i.e. QOM object wanting to know its
> name. I've did something similar for memory_backend except of cutting
> of parent's path.
> Could we make and use a more generic accessor for object name?
Yes, I think we can do it in object.c. Will send another revision.
Stefan
- [Qemu-devel] [PATCH v4 0/6] dataplane: switch to N:M devices-per-thread model, Stefan Hajnoczi, 2014/02/21
- [Qemu-devel] [PATCH v4 1/6] rfifolock: add recursive FIFO lock, Stefan Hajnoczi, 2014/02/21
- [Qemu-devel] [PATCH v4 2/6] aio: add aio_context_acquire() and aio_context_release(), Stefan Hajnoczi, 2014/02/21
- [Qemu-devel] [PATCH v4 3/6] iothread: add I/O thread object, Stefan Hajnoczi, 2014/02/21
- [Qemu-devel] [PATCH v4 4/6] qdev: add get_pointer_and_free() for temporary strings, Stefan Hajnoczi, 2014/02/21
- [Qemu-devel] [PATCH v4 5/6] iothread: add "iothread" qdev property type, Stefan Hajnoczi, 2014/02/21
- [Qemu-devel] [PATCH v4 6/6] dataplane: replace internal thread with IOThread, Stefan Hajnoczi, 2014/02/21