Re: [Qemu-devel] Contribution - L2TPv3 transport

[Paolo Bonzini]

Il 28/02/2014 16:06, Eric Blake ha scritto:
> On 02/28/2014 07:00 AM, Paolo Bonzini wrote:
> > Il 28/02/2014 14:40, Eric Blake ha scritto:
> > > These should probably be 'int', not 'str'.  If you have to hand-parse a
> > > string into a numeric value, you encoded the QMP wrong.
> >
> > Eric, note that this is not QMP.  It is only used for option parsing.
>
> But still, shouldn't option parsing be able to take advantage of
> non-'str' typing to ease the task of handling numeric parameters?

Indeed, and I pointed this out in my review as well.  But the tradeoffs 
are a bit different, as you have already found out in the past.

Paolo