Re: [Qemu-devel] [PATCH 0/3] Enable x2apic by default on KVM

[Andreas Färber]

Am 19.02.2014 20:13, schrieb Michael S. Tsirkin:
> On Wed, Feb 19, 2014 at 11:58:09AM -0300, Eduardo Habkost wrote:
>> This is the approach I believe was agreed upon during the last QEMU 
>> developers
>> conf call (sorry I didn't join, the meeting timezone change confused me).
> 
> Yes.

Matches my understanding as well.

>> Some may notice that representing this new behavior using solely default 
>> values
>> on CPU properties may be a little difficult. Making it possible to replace
>> x86_cpu_compat_disable_kvm_features() with compat_props entries may be an
>> interesting problem, too.
> 
> Acked-by: Michael S. Tsirkin <address@hidden>

Paolo clarified that he is okay with me going ahead with the series, so
let's get the behavior changed first and then we can later worry about
refactoring the compat infrastructure.

Thanks, applied to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

One question for 3/3 though: Is it "running KVM", "running on KVM",
"running in KVM" or "running with KVM"? I was unsure, so left it as is.

Regards,
Andreas

>> Eduardo Habkost (3):
>>   target-i386: Make kvm_default_features an array
>>   target-i386: Introduce x86_cpu_compat_disable_kvm_features()
>>   target-i386: Enable x2apic by default on KVM

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg