[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/13] qjson.h: Remove spurious GCC_FMT_ATTR markup f
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 08/13] qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration |
Date: |
Tue, 4 Mar 2014 10:15:56 +0400 |
From: Peter Maydell <address@hidden>
The function qobject_from_json() doesn't actually allow its
argument to be a format string -- it passes a NULL va_list*
to qobject_from_jsonv(), and the parser code will then never
actually interpret %-escape sequences (it tests whether the
va_list pointer is NULL and will stop with a parse error).
The spurious attribute markup causes clang warnings in some
of the test cases where we programmatically construct JSON
to feed to qobject_from_json():
tests/test-qmp-input-visitor.c:76:35: warning: format string is not a
string literal (potentially insecure) [-Wformat-security]
data->obj = qobject_from_json(json_string);
^~~~~~~~~~~
Remove the incorrect attribute.
Signed-off-by: Peter Maydell <address@hidden>
Suggested-by: Paolo Bonzini <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
include/qapi/qmp/qjson.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qapi/qmp/qjson.h b/include/qapi/qmp/qjson.h
index 73351ed..ee4d31a 100644
--- a/include/qapi/qmp/qjson.h
+++ b/include/qapi/qmp/qjson.h
@@ -19,7 +19,7 @@
#include "qapi/qmp/qobject.h"
#include "qapi/qmp/qstring.h"
-QObject *qobject_from_json(const char *string) GCC_FMT_ATTR(1, 0);
+QObject *qobject_from_json(const char *string);
QObject *qobject_from_jsonf(const char *string, ...) GCC_FMT_ATTR(1, 2);
QObject *qobject_from_jsonv(const char *string, va_list *ap) GCC_FMT_ATTR(1,
0);
--
1.7.10.4
- [Qemu-devel] [PULL 00/13] Trivial patches for 2014-03-04, Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 05/13] tcg: Fix typo in comment (dependancies -> dependencies), Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 01/13] include/qemu/host-utils.h: Trivial typo: ctz->cto, Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 02/13] object: Report type in error when not user creatable., Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 06/13] stubs: Optimize dependencies for gdbstub.c, Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 13/13] vl: Remove unneeded include file, Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 09/13] util/iov: Use qemu/sockets.h instead of conditional code, Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 11/13] qemu-img: Remove unneeded include files, Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 03/13] bswap: Modify prototype of stb_p (avoid type conversions), Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 07/13] tests/test-int128: Don't use __noclone__ attribute on clang, Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 08/13] qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration,
Michael Tokarev <=
- [Qemu-devel] [PULL 12/13] qga: Remove unneeded include file, Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 04/13] bswap: Modify prototypes of st[wl]_{le, be}_p (avoid type conversions), Michael Tokarev, 2014/03/04
- [Qemu-devel] [PULL 10/13] exec: Remove unneeded include files, Michael Tokarev, 2014/03/04
- Re: [Qemu-devel] [PULL 00/13] Trivial patches for 2014-03-04, Peter Maydell, 2014/03/04