qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2 0/1] e1000: add the ability to select among sever


From: Romain Dolbeau
Subject: [Qemu-devel] [PATCH v2 0/1] e1000: add the ability to select among several specific
Date: Tue, 4 Mar 2014 10:08:42 +0100

Hello,

This patch builds up on the previous version.

I adds this ability to select a specific variant of the e1000 virtual
ethernet from the command-line (see details already mentioned
in the previous patch below).

It also add supports for the 82566DM device, an ICH9 device,
found e.g. with the P35 chipset (a close relative to the Q35
chipset).

-------------------
Previously
only a single device was available, selected at compile time.
This helps for guests with limited hardware support, as with
this patch not all guests are required to use the same device.

So for instance to use the emulated 82545EM in OSX[1], a user
would add e.g. the options:

"-netdev user,id=mynet0 -device 82545EM,netdev=mynet0"

Note that the value 'e1000' is retained to mean "whatever
is the compiled-in default", as previously.

There's also some comments to help future developers to
identify relevant informations in the documentations.
There's also a couple of fixed values for constants
(didn't match the current driver).

Known cosmetic issues:
1) Some lines are long than 80 characters to avoid breaking
down URLs and titles.
2) One of the array initializer generates the error:
####
ERROR: space prohibited before open square bracket '['
#107: FILE: hw/net/e1000.c:256:
+    [PHY_ID1] = 0x141,                          [PHY_ID2] = 0xc20,
####
Despite being formatted exactly like the surrounding lines
(minus the tabs, another source of error in checkpatch.pl).
-------------------

Cordially,

Romain Dolbeau

[1] See <http://www.contrib.andrew.cmu.edu/~somlo/OSXKVM/>
    for details

-- 
Romain Dolbeau



reply via email to

[Prev in Thread] Current Thread [Next in Thread]