[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] hw/core: introduced qemu machine as QOM
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] hw/core: introduced qemu machine as QOM object |
Date: |
Fri, 07 Mar 2014 12:31:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 05.03.2014 18:30, schrieb Marcel Apfelbaum:
> +struct MachineState {
> + /*< private >*/
> + Object parent_obj;
> + /*< public >*/
> +
> + char *accel;
> + bool kernel_irqchip;
> + int kvm_shadow_mem;
> + char *kernel;
> + char *initrd;
> + char *append;
> + char *dtb;
> + char *dumpdtb;
> + int phandle_start;
> + char *dt_compatible;
> + bool dump_guest_core;
> + bool mem_merge;
> + bool usb;
> + char *firmware;
> +
> + QEMUMachineInitArgs init_args;
> +};
If I'm reading directly, init_args is the only field used in this
3-patch series. Should we drop the unused ones for now? Or do you think
we should get the whole conversion done for 2.0 and therefore keep them?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg