[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qcow2: Don't write with BDRV_O_INCOMING
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] qcow2: Don't write with BDRV_O_INCOMING |
|
Date: |
Tue, 11 Mar 2014 09:25:28 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/11/2014 08:15 AM, Kevin Wolf wrote:
> qcow2_open() causes writes when repairing an image with the dirty flag
> set and when clearing autoclear flags. It shouldn't do this when another
> qemu instance is still actively working on this image file.
>
> One effect of the bug is that images may have a cleared dirty flag while
> the migration source host still has it in use with lazy refcounts
> enabled, so refcounts are not accurate and the dirty flag must remain
> set.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qcow2.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature