Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version

[Peter Maydell]

On 11 March 2014 15:49, Jan Kiszka <address@hidden> wrote:
> pthread_setname_np was introduced with 2.12.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
>  util/qemu-thread-posix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c
> index 45113b4..960d7f5 100644
> --- a/util/qemu-thread-posix.c
> +++ b/util/qemu-thread-posix.c
> @@ -420,7 +420,7 @@ void qemu_thread_create(QemuThread *thread, const char 
> *name,
>      if (err)
>          error_exit(err, __func__);
>
> -#ifdef _GNU_SOURCE
> +#if defined(__GLIBC__) && (__GLIBC__ > 2 || (__GLIBC__ == 2 && 
> __GLIBC_MINOR__ >= 12))
>      if (name_threads) {
>          pthread_setname_np(thread->thread, name);
>      }
> --
> 1.8.1.1.298.ge7eed54

Can we have a configure test for the function instead, please?
We don't generally do tests for specific glibc versions
(among other things, glibc is not the only C library we
might be compiled against -- consider MacOSX, the BSDs,
and occasionally somebody tries to compile against one
of the embedded libcs).

thanks
-- PMM