[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-io: Fix warnings from static code analysis
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-io: Fix warnings from static code analysis |
Date: |
Wed, 12 Mar 2014 10:20:05 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 05, 2014 at 10:23:00PM +0100, Stefan Weil wrote:
> Smatch complains about several global symbols which should be local.
>
> Add the missing 'static' attributes and move the 'extern' declaration
> of variable qemuio_misalign to qemu-io.h. This variable also changes
> the type from 'int' to 'bool' which better fits documents its use.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> include/qemu-io.h | 2 ++
> qemu-io-cmds.c | 2 +-
> qemu-io.c | 7 +++----
> 3 files changed, 6 insertions(+), 5 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan