Re: [Qemu-devel] [PULL for-2.0-rc0 00/58] QOM CPUState patch queue 2014-03-13

[Peter Maydell]

On 13 March 2014 14:54, Andreas Färber <address@hidden> wrote:
> Hello Peter,
>
> This is my current QOM CPU patch queue. Please pull.
>
> Since this touches on bsd-user code, request to apply the build fix first.
>
> NB: I was only able to test x86/ppc/arm KVM this time; s390x KVM was 
> re-reviewed only.
>
> Regards,
> Andreas
>
> Cc: Peter Maydell <address@hidden>
> Cc: Anthony Liguori <address@hidden>
>
> Cc: Eduardo Habkost <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Cc: Christian Borntraeger <address@hidden>
>
> The following changes since commit be86c53c058d75fc3938b1b54f363259f282b3d5:
>
>   Merge remote-tracking branch 'remotes/afaerber/tags/ppc-for-2.0' into 
> staging (2014-03-13 13:19:46 +0000)
>
> are available in the git repository at:
>
>
>   git://github.com/afaerber/qemu-cpu.git tags/qom-cpu-for-2.0
>
> for you to fetch changes up to 98f11363e7add1e750f76e3d81750348f0470c29:
>
>   user-exec: Change exception_action() argument to CPUState (2014-03-13 
> 15:35:04 +0100)

Fails to compile on systems without CONFIG_INT128 (eg 32 bit host):

/root/qemu/target-s390x/int_helper.c: In function ‘helper_divu64’:
/root/qemu/target-s390x/int_helper.c:111:9: error: passing argument 1
of ‘cpu_abort’ from incompatible pointer type [-Werror]
In file included from /root/qemu/include/exec/cpu-all.h:26:0,
                 from /root/qemu/target-s390x/cpu.h:41,
                 from /root/qemu/target-s390x/int_helper.c:21:
/root/qemu/include/qom/cpu.h:620:37: note: expected ‘struct CPUState
*’ but argument is of type ‘struct CPUS390XState *’
cc1: all warnings being treated as errors

thanks
-- PMM