Re: [Qemu-devel] [PULL 7/7] gtk: Don't warp absolute pointer

[Dave Airlie]

On Thu, Mar 13, 2014 at 8:46 PM, Gerd Hoffmann <address@hidden> wrote:
> From: Cole Robinson <address@hidden>

Wierd I wrote and submitted these months ago, and they were promptly ignored,

Glad you had to find bugs all over again an reinvent the wheel,

Dave.

>
> This matches the behavior of SDL, and makes the mouse usable when
> using -display gtk -vga qxl
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1051724
> Signed-off-by: Cole Robinson <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  ui/gtk.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 330dc13..ef7cb47 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -340,6 +340,10 @@ static void gd_mouse_set(DisplayChangeListener *dcl,
>      GdkDeviceManager *mgr;
>      gint x_root, y_root;
>
> +    if (qemu_input_is_absolute()) {
> +        return;
> +    }
> +
>      dpy = gtk_widget_get_display(s->drawing_area);
>      mgr = gdk_display_get_device_manager(dpy);
>      gdk_window_get_root_coords(gtk_widget_get_window(s->drawing_area),
> @@ -355,6 +359,10 @@ static void gd_mouse_set(DisplayChangeListener *dcl,
>      GtkDisplayState *s = container_of(dcl, GtkDisplayState, dcl);
>      gint x_root, y_root;
>
> +    if (qemu_input_is_absolute()) {
> +        return;
> +    }
> +
>      gdk_window_get_root_coords(gtk_widget_get_window(s->drawing_area),
>                                 x, y, &x_root, &y_root);
>      gdk_display_warp_pointer(gtk_widget_get_display(s->drawing_area),
> --
> 1.8.3.1
>
>