[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] qcow2: Correct comment for realloc_refco
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] qcow2: Correct comment for realloc_refcount_block() |
Date: |
Mon, 17 Mar 2014 23:19:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/17/14 23:04, Max Reitz wrote:
> Contrary to the comment describing this function's behavior, it does not
> return 0 on success, but rather the offset of the newly allocated
> cluster. This patch adjusts the comment accordingly to reflect the
> actual behavior.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2-refcount.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
> index 6151148..3f2ed08 100644
> --- a/block/qcow2-refcount.c
> +++ b/block/qcow2-refcount.c
> @@ -1383,7 +1383,7 @@ static int write_reftable_entry(BlockDriverState *bs,
> int rt_index)
> * does _not_ decrement the reference count for the currently occupied
> cluster.
> *
> * This function prints an informative message to stderr on error (and
> returns
> - * -errno); on success, 0 is returned.
> + * -errno); on success, the offset of the newly allocated cluster is
> returned.
> */
> static int64_t realloc_refcount_block(BlockDriverState *bs, int
> reftable_index,
> uint64_t offset)
>
Reviewed-by: Laszlo Ersek <address@hidden>