Re: [Qemu-devel] [PULL for-2.0 7/7] linux-user: Implement capget, capset

[Peter Maydell]

On 19 March 2014 15:10, Laurent Desnogues <address@hidden> wrote:
>   Hello,
>
> On Wed, Mar 19, 2014 at 3:03 PM,  <address@hidden> wrote:
>> From: Peter Maydell <address@hidden>
>>
>> +        if (header.version != _LINUX_CAPABILITY_VERSION_1) {
>
> Sorry for spotting this late, but older kernels (in my case
> 2.6.18-238.el5, CentOS 5.6) don't have
> _LINUX_CAPABILITY_VERSION_1 defined.

Oops.

> I think
> _LINUX_CAPABILITY_VERSION should be used instead
> in that case.

Simplest is to just use the non _1 suffix version always;
later kernels define that for source compatibility.

thanks
-- PMM