Re: [Qemu-devel] [PATCH v7 for 2.0 4/4] qcow2: Add full image preallocation option

[Kevin Wolf]

Am 17.03.2014 um 07:53 hat Hu Tao geschrieben:
> This adds a preallocation=full mode to qcow2 image creation, which
> creates a non-sparse image file.
> 
> Signed-off-by: Hu Tao <address@hidden>

I see that you changed the implementation from bdrv_preallocate() to
bdrv_create() options in v4 after Stefan had asked whether
bdrv_preallocate() was really necessary or just complicating things.

In hindsight, do you really think the new code is simpler? I certainly
think this one is rather adventurous and the formulas to precalculate
the image file size are easy to get wrong.

Kevin