[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on
From: |
Marcel Apfelbaum |
Subject: |
Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines |
Date: |
Fri, 21 Mar 2014 00:41:09 +0200 |
On Thu, 2014-03-20 at 22:17 +0000, Peter Maydell wrote:
> On 20 March 2014 22:06, Marcel Apfelbaum <address@hidden> wrote:
> > On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote:
> >> Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto:
> >> > +# All known versions of iasl on BE machines are broken.
> >> > +# TODO: add detection code once a non-broken version makes an
> >> > appearance.
> >> > +if ($iasl -h > /dev/null 2>&1) &&
> >> > + (lscpu | grep "Byte Order" | grep --quiet "Little Endian" ); then
> >>
> >> lscpu is not portable.
> > I am open to suggestions...
>
> echo "trivial iasl source" | iasl --compile-options | iasl
> --disassemble-options | grep "error"
>
> Fill in the handwaving with actual syntax ;-)
Thanks Peter!
Problem with this solution is that if we start from the source,
it will compile into a *wrong* AML (e.g header length will be BE and not LE),
then the disassemble will *succeed* (!!!).
However, the expected AML file will be in the right format and fail :(.
I can use one of the expected AML files, but it would not be elegant
to use a test file in the configuration script.
What about Laszlo's idea? Would something like:
X=$(printf '\336\255\276\357' | od -A n -t x4) be acceptable ?
Thanks,
Marcel
>
> thanks
> -- PMM
- [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Marcel Apfelbaum, 2014/03/20
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Michael S. Tsirkin, 2014/03/23
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Laszlo Ersek, 2014/03/20
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Marcel Apfelbaum, 2014/03/20
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Laszlo Ersek, 2014/03/20
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Paolo Bonzini, 2014/03/20
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Michael S. Tsirkin, 2014/03/23
- Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines, Peter Maydell, 2014/03/23