[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH 11/16] Choose output visitor based on env variab
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [RFC PATCH 11/16] Choose output visitor based on env variable |
Date: |
Tue, 25 Mar 2014 20:17:22 +0000 |
From: "Dr. David Alan Gilbert" <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
savevm.c | 39 ++++++++++++++++++++++++++++++++-------
1 file changed, 32 insertions(+), 7 deletions(-)
diff --git a/savevm.c b/savevm.c
index 7431773..25e92f2 100644
--- a/savevm.c
+++ b/savevm.c
@@ -26,6 +26,7 @@
#include "qemu-common.h"
#include "qapi/qemu-file-binary-input-visitor.h"
#include "qapi/qemu-file-binary-output-visitor.h"
+#include "qapi/qemu-file-debug-output-visitor.h"
#include "hw/hw.h"
#include "hw/qdev.h"
#include "net/net.h"
@@ -524,6 +525,35 @@ bool qemu_savevm_state_blocked(Error **errp)
return false;
}
+/* Return a visitor for use on the QEMUFile; visit_destroy should be
+ * called on it to clean it up.
+ */
+static Visitor *qemu_savevm_get_visitor(QEMUFile *f)
+{
+ char *formatvar = getenv("QEMUMIGFORMAT");
+
+ if (formatvar && (!strcmp(formatvar, "debug"))) {
+ QemuFileDebugOutputVisitor *qfdov =
+ qemu_file_debug_output_visitor_new(f);
+ Visitor *v = qemu_file_debug_output_get_visitor(qfdov);
+
+ qemu_file_set_tmp_visitor(f, v);
+ return v;
+ }
+
+ if (formatvar) {
+ error_report("QEMUMIGFORMAT set to unknown value '%s'", formatvar);
+ assert(0);
+ }
+
+ QemuFileBinOutputVisitor *qfbov = qemu_file_bin_output_visitor_new(f);
+ Visitor *v = qemu_file_bin_output_get_visitor(qfbov);
+
+ qemu_file_set_tmp_visitor(f, v);
+
+ return v;
+}
+
void qemu_savevm_state_begin(QEMUFile *f,
const MigrationParams *params)
{
@@ -531,10 +561,7 @@ void qemu_savevm_state_begin(QEMUFile *f,
int ret;
Error *local_err = NULL;
SectionHeader sh;
-
- QemuFileBinOutputVisitor *qfbov = qemu_file_bin_output_visitor_new(f);
- Visitor *v = qemu_file_bin_output_get_visitor(qfbov);
- qemu_file_set_tmp_visitor(f, v);
+ Visitor *v = qemu_savevm_get_visitor(f);
QTAILQ_FOREACH(se, &savevm_handlers, entry) {
if (!se->ops || !se->ops->set_params) {
@@ -781,13 +808,11 @@ static int qemu_savevm_state(QEMUFile *f)
static int qemu_save_device_state(QEMUFile *f)
{
+ Visitor *v = qemu_savevm_get_visitor(f);
SaveStateEntry *se;
Error *local_err;
SectionHeader sh;
- QemuFileBinOutputVisitor *qfbov = qemu_file_bin_output_visitor_new(f);
- qemu_file_set_tmp_visitor(f, qemu_file_bin_output_get_visitor(qfbov));
- Visitor *v = qemu_file_bin_output_get_visitor(qfbov);
int32_t section_type;
cpu_synchronize_all_states();
--
1.8.5.3
- [Qemu-devel] [RFC PATCH 08/16] Visitor: Output path, (continued)
- [Qemu-devel] [RFC PATCH 08/16] Visitor: Output path, Dr. David Alan Gilbert (git), 2014/03/25
- [Qemu-devel] [RFC PATCH 09/16] Visitor: Load path, Dr. David Alan Gilbert (git), 2014/03/25
- [Qemu-devel] [RFC PATCH 12/16] BER Visitor: Create output visitor, Dr. David Alan Gilbert (git), 2014/03/25
- [Qemu-devel] [RFC PATCH 13/16] BER Visitor: Create input visitor, Dr. David Alan Gilbert (git), 2014/03/25
- [Qemu-devel] [RFC PATCH 14/16] Start some BER format docs, Dr. David Alan Gilbert (git), 2014/03/25
- [Qemu-devel] [RFC PATCH 15/16] ASN.1 schema for new migration format, Dr. David Alan Gilbert (git), 2014/03/25
- [Qemu-devel] [RFC PATCH 01/16] Visitor: Add methods for migration format use, Dr. David Alan Gilbert (git), 2014/03/25
- [Qemu-devel] [RFC PATCH 03/16] qemu-file: Add set/get tmp_visitor, Dr. David Alan Gilbert (git), 2014/03/25
- [Qemu-devel] [RFC PATCH 07/16] Visitor: Binary compatible input visitor, Dr. David Alan Gilbert (git), 2014/03/25
- [Qemu-devel] [RFC PATCH 10/16] Visitor: Common types to use visitors, Dr. David Alan Gilbert (git), 2014/03/25
- [Qemu-devel] [RFC PATCH 11/16] Choose output visitor based on env variable,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [RFC PATCH 16/16] Wire in BER visitors, Dr. David Alan Gilbert (git), 2014/03/25
- Re: [Qemu-devel] [RFC PATCH 00/16] visitor+BER migration format, Michael S. Tsirkin, 2014/03/25