[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.0 3/7] pm_smbus: correctly report unclaime
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH for-2.0 3/7] pm_smbus: correctly report unclaimed cycles |
Date: |
Mon, 31 Mar 2014 23:38:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 31.03.2014 18:26, schrieb Paolo Bonzini:
> Without this patch, i2cdetect will report all addresses as present.
> With it, only 0x50..0x57 are present.
>
> Before:
>
> 0 1 2 3 4 5 6 7 8 9 a b c d e f
> 00: 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f
> 10: 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f
> 20: 20 21 22 23 24 25 26 27 28 29 2a 2b 2c 2d 2e 2f
> 30: 30 31 32 33 34 35 36 37 38 39 3a 3b 3c 3d 3e 3f
> 40: 40 41 42 43 44 45 46 47 48 49 4a 4b 4c 4d 4e 4f
> 50: 50 51 52 53 54 55 56 57 58 59 5a 5b 5c 5d 5e 5f
> 60: 60 61 62 63 64 65 66 67 68 69 6a 6b 6c 6d 6e 6f
> 70: 70 71 72 73 74 75 76 77
>
> After:
>
> 0 1 2 3 4 5 6 7 8 9 a b c d e f
> 00: -- -- -- -- -- -- -- -- -- -- -- -- --
> 10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> 20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> 30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> 40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> 50: 50 51 52 53 54 55 56 57 -- -- -- -- -- -- -- --
> 60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> 70: -- -- -- -- -- -- -- --
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/i2c/pm_smbus.c | 63
> ++++++++++++++++++++++++++++++++++++-------------------
> 1 file changed, 41 insertions(+), 22 deletions(-)
The pure goto refactoring looks okay to me; don't have a datasheet to
check the changing error smb_stat behavior against though, so FWIW
Reviewed-by: Andreas Färber <address@hidden>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH for-2.0 0/7] SMBus and tmp105 fixes, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 1/7] smbus: allow returning an error from reads, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 2/7] smbus: return -1 if nothing found at the given address, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 3/7] pm_smbus: correctly report unclaimed cycles, Paolo Bonzini, 2014/03/31
- Re: [Qemu-devel] [PATCH for-2.0 3/7] pm_smbus: correctly report unclaimed cycles,
Andreas Färber <=
- [Qemu-devel] [PATCH for-2.0 4/7] tmp105: read temperature in milli-celsius, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 5/7] tmp105-test: wrap simple building blocks for testing, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 6/7] tmp105-test: add a second sensor and test that one, Paolo Bonzini, 2014/03/31
- [Qemu-devel] [PATCH for-2.0 7/7] tmp105-test: test QOM property and precision, Paolo Bonzini, 2014/03/31
- Re: [Qemu-devel] [PATCH for-2.0 0/7] SMBus and tmp105 fixes, Andreas Färber, 2014/03/31