qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.0? 2/2] cpu-exec: Unlock tb_lock if we lon


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH for-2.0? 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation
Date: Thu, 03 Apr 2014 09:51:47 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 04/03/2014 09:45 AM, Peter Maydell wrote:
> +            if (have_tb_lock) {
> +                spin_unlock(&tcg_ctx.tb_ctx.tb_lock);
> +            }

It ought not matter, since we ought to exit the loop on the next round, but i
have a strong preference for resetting have_tb_lock here.

Otherwise, this is nicely self-contained.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]