[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/6] qemu-img: Enable progress output for com
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 4/6] qemu-img: Enable progress output for commit |
|
Date: |
Tue, 08 Apr 2014 10:53:43 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/08/2014 09:34 AM, Kevin Wolf wrote:
> Am 08.04.2014 um 14:50 hat Max Reitz geschrieben:
>> Implement progress output for the commit command by querying the
>> progress of the block job.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> ---
>>
>> info = block_job_query(job);
>>
>> + if (info->offset) {
>> + if (!mod_offset) {
>
> On a fully populated image this doesn't look entirely right. I think the
> first 2 MB (or whatever the buffer size is) will be disregarded in the
> calculation, even though they are real work that is done.
Is there any (easy) way to calculate how many dirty sectors remain to be
committed, to use that rather than the image size as the job percentage
remaining?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature