Re: [Qemu-devel] [PATCH qemu 5/6] virtio-input: control device

[Michael S. Tsirkin]

On Thu, Apr 10, 2014 at 02:10:20PM +0200, Gerd Hoffmann wrote:
> On Do, 2014-04-10 at 14:05 +0300, Michael S. Tsirkin wrote:
> > On Thu, Apr 10, 2014 at 11:07:53AM +0200, Gerd Hoffmann wrote:
> > > Device for sending non-input control messages to the guest.  For now
> > > this is only a single event: shutdown requests are sent as power button
> > > press to the guest.
> > > 
> > > Possible other use is signaling sound volume changes to the guest (via
> > > EV_ABS / ABS_VOLUME).  I expect we'll find more over time.
> > > 
> > > Signed-off-by: Gerd Hoffmann <address@hidden>
> > 
> > Why not use a keyboard device for this?
> 
> >From the guests point of view this is looks like a keyboard.  A keyboard
> with a single key: power.
> 
> I prefer a clear separation between devices being feed from user input
> and the control device which monitors other event sources (powerdown
> notifier).
> 
> There is no fundamental reason why this can't live in the emulated
> keyboard though.
> 
> cheers,
>   Gerd
>

Well I have a keyboard with volume keys - sleep and wakeup buttons too.
Not power but that's not out of the realm of possibility.
If we want to be able to pass that through, it should work as a
virtio keyboard right?
 
-- 
MST