[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qapi-commands.py generates code that uses uninitialized
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] qapi-commands.py generates code that uses uninitialized variables |
|
Date: |
Fri, 11 Apr 2014 08:27:25 +0100 |
On 11 April 2014 02:40, Eric Blake <address@hidden> wrote:
> We uncovered a real bug that would be fixed by this patch:
> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg01745.html
No, that's a bug in the called code. The API here defines
that for optional parameters, if the have_foo bool is false
then the foo argument isn't set. The generated code
can't know the correct default value (it just happens
to be 0 in the case you point out, but what if the default
speed were 100?) so this must be handled by the called
code.
thanks
-- PMM