[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.0] configure: Make stack-protector test ch
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-devel] [PATCH for-2.0] configure: Make stack-protector test check both compile and link |
Date: |
Sat, 12 Apr 2014 02:27:01 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/12/2014 02:13 AM, Peter Maydell wrote:
> Since we use the -fstack-protector argument at both compile and
> link time in the build, we must check that it works with both
> a compile and a link:
> * MacOSX only fails in the compile step, not linking
> * some gcc cross environments only fail at the link stage (if they
> require a libssp and it's not present for some reason)
>
> Signed-off-by: Peter Maydell <address@hidden>
yay! thanks!
Tested-by: Alexey Kardashevskiy <address@hidden>
> ---
> configure | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index c85475f..69b9f56 100755
> --- a/configure
> +++ b/configure
> @@ -1448,7 +1448,10 @@ done
> if test "$stack_protector" != "no" ; then
> gcc_flags="-fstack-protector-strong -fstack-protector-all"
> for flag in $gcc_flags; do
> - if do_cc $QEMU_CFLAGS -Werror $flag -c -o $TMPO $TMPC ; then
> + # We need to check both a compile and a link, since some compiler
> + # setups fail only on a .c->.o compile and some only at link time
> + if do_cc $QEMU_CFLAGS -Werror $flag -c -o $TMPO $TMPC &&
> + compile_prog "-Werror $flag" ""; then
> QEMU_CFLAGS="$QEMU_CFLAGS $flag"
> LIBTOOLFLAGS="$LIBTOOLFLAGS -Wc,$flag"
> break
>
--
Alexey