Re: [Qemu-devel] [QEMU v5 PATCH 00/18] SMBIOS: build full tables in QEMU

[Kevin O'Connor]

On Fri, Apr 11, 2014 at 12:11:40PM -0400, Gabriel L. Somlo wrote:
> Quick highlights:
> 
>   - after 10/18, we're generating tables 100% consistent with SeaBiOS
> 
>   - after 14/18, we use e820 to generate type 19 (memory area) tables
> 
>   - after 18/18, we expect SeaBIOS to check fw_cfg for a full set of
>     tables and an entry point (e.g., we need a version of SeaBIOS which
>     has applied this patch:
> 
>       http://www.seabios.org/pipermail/seabios/2014-April/007823.html
> 
> Please let me know what you all think.

Thanks.  I'm not a QEMU expert, but I did review your patches.  The
patch series looks good to me and I think this is the right direction.

As a minor quibble, I think patch 18 should make type0 required
instead of optional (once there are the new fw_cfg entries there is no
harm in always producing type0).  Also, it would be nice to move up
patch 18 to after patch 10 - that way an end-to-end test between
old/new smbios with the new interface could be done.  I defer to
regular qemu developers on these comments though.

-Kevin