[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and ge
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device() |
Date: |
Tue, 15 Apr 2014 10:49:06 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Chen Gang <address@hidden> writes:
> In "vl.c", at least, we can simplify the code below, so can let readers
> read professional C code (especially for new readers, which often start
> reading code at main function).
>
> - remove useless 'continue' in main().
>
> - remove redundant local variable 'res' in get_boot_device().
>
> - remove local variable 'args' in the middle of code block in main().
>
> The following 3 patches are for the 3 'remove' above.
>
> And "vl.c" has a very long function main() which is about 17K lines.
> Next, it can be split into sub-functions (so can bypass another code
> style issue: multiple "{...}" styles within "swith(...)").
>
>
> Signed-off-by: Chen Gang <address@hidden>
> ---
> vl.c | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
In future submissions, please send the patches in-reply-to the cover
letter, not chained together in-reply-to the previous part. Check out
git-send-email --no-chain-reply-to.
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, (continued)
- Re: [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Peter Crosthwaite, 2014/04/14
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Peter Crosthwaite, 2014/04/14
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue', Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/14
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(),
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Markus Armbruster, 2014/04/15
- Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(), Chen Gang, 2014/04/15