Re: [Qemu-devel] [PATCH 2/7] megasas: Enable MSI-X support

[Andreas Färber]

Am 16.04.2014 18:32, schrieb Alexander Graf:
> 
> On 16.04.14 16:44, Hannes Reinecke wrote:
>> MSI-X support has been fixed in qemu, so we can enable it again.
>>
>> Signed-off-by: Hannes Reinecke <address@hidden>
>> ---
>>   hw/scsi/megasas.c | 19 ++++++-------------
>>   1 file changed, 6 insertions(+), 13 deletions(-)
>>
>> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
>> index 1781525..df45286 100644
>> --- a/hw/scsi/megasas.c
>> +++ b/hw/scsi/megasas.c
>> @@ -2084,7 +2084,8 @@ static const VMStateDescription vmstate_megasas = {
>>       .minimum_version_id = 0,
>>       .minimum_version_id_old = 0,
>>       .fields      = (VMStateField[]) {
>> -        VMSTATE_PCI_DEVICE(parent_obj, MegasasState),
>> +        VMSTATE_PCIE_DEVICE(parent_obj, MegasasState),
>> +        VMSTATE_MSIX(parent_obj, MegasasState),
> 
> This requires a version change for vmstate, no?

The PCI -> PCIE change yes. mst might have objections for bumping an x86
PCI device?

The MSIX addition should be safe AFAICT since old versions would not
enable MSI-X.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg