[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Bug 1310324] [NEW] Commit 0f842f8a introduces regressi
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [Bug 1310324] [NEW] Commit 0f842f8a introduces regression when using tcg-interpreter |
Date: |
Mon, 21 Apr 2014 15:14:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
Am 20.04.2014 19:19, schrieb Giovanni Mascellani:
> Public bug reported:
>
> Hi.
>
> Commit 0f842f8a246f2b5b51a11c13f933bf7a90ae8e96 apparently introduces a
> regression when using --enable-tcg-interpreter. The regression is
> manifested as follows:
>
That commit changed the use of the GETPC macro. I just tried to debug
the tci.c code and noticed that cputlb.c no longer works as expected:
That file redefines GETPC before including exec/softmmu_template.h. This
redefinition is no longer used because the included file now uses
GETPC_ADJ und GETRA.
This is not specific for the TCG interpreter, but I don't know how the
normal TCG is affected.
I also noticed that other code like target-i386/seg_helper.c which
includes exec/softmmu_template.h also results in undefined usage of the
GETRA macro.
Richard, I used the appended patch to debug this problem. It raises an
assertion whenever GETRA is used outside of tcg_qemu_tb_exec loop.
Regards
Stefan
patch
Description: Text document
- [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 001/124] savevm: Ignore minimum_version_id_old if there is no load_state_old, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_minimum_id_old (arm), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 002/124] savevm: Remove all the unneded version_minimum_id_old (usb), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 005/124] savevm: Remove all the unneded version_minimum_id_old (x86), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 003/124] savevm: Remove all the unneded version_minimum_id_old (ppc), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 006/124] savevm: Remove all the unneded version_minimum_id_old (rest), Juan Quintela, 2014/04/21