qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive)


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive)
Date: Mon, 21 Apr 2014 13:49:48 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

Il 21/04/2014 13:34, Peter Maydell ha scritto:
Mostly just that I think that for vmstate definitions "this new field
was added in version X" is natural and normal, whereas other
test functions are odd and generally the exception. So a simple
way to indicate minimum version for fields seems useful to retain.
I don't mind if you want to unify the underlying implementation,
but I would prefer to retain the _V macros for vmstate definitions
to use (and it has the additional advantage of avoiding the need for
touching lots of devices...)

I agree. In many cases, _TEST is a huge review warning sign that subsections should have been used instead.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]